Initial work for versionsuffix and external-id - #2555
Merged
Merged
Conversation
This is intended to at least start laying groundwork and implementation for two features in the component model that this repository does not yet implement: * `(versionsuffix "...")` for components -- introduced in WebAssembly/component-model#536 this is intended to pave a path forward to canonicalizing versions in component imports/exports in the future. For example where today you'd import `a:b/c@1.0.0` tomorrow you'd import `a:b/c@1`. This is not yet fully integrated into `wit-component`, however, and further work will be necessary for bindings generators as well to take advantage of this. It's all encoded in the same place as `external-id`, though, so I figured I'd at least start to lay the groundwork. * `(external-id "...")` for components -- being introduced in WebAssembly/component-model#672 this is intended to attach arbitrary metadata to imports/exports in a component. This is surfaced in WIT as an `@external-id("...")` attribute. This should be hooked up throughout this implementation to WIT and such such that the implementation is intended to be complete. There's probably something I forgot, but all the major pieces should be there. The `versionsuffix` parsing/validation is gated by a new `cm-canon-names` feature, and the `external-id` parsing/validation is gated behind the preexisting `cm-implements` feature to match the specification's classification.
This was referenced Jul 1, 2026
Contributor
|
Heads up that gating Right now the Explainer's motivating example puts (component $ESM
(import "slugify"
(external-id "https://esm.unpkg.com/slugify@1.6.6")
(func (param "text" string) (result string)))
) |
PhoebeSzmucer
pushed a commit
to PhoebeSzmucer/wasm-tools
that referenced
this pull request
Jul 7, 2026
This commit extends the work done in bytecodealliance#2555 to support `@external-id` on all component model items and notably in more locations in WIT. This required mostly work on the WIT side of things to ensure that it's plumbed everywhere.
This was referenced Jul 23, 2026
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Sep 9, 2026
Added in bytecodealliance#2555 but I forgot to document it at the time.
chacailline
pushed a commit
to chacailline/wasm-tools
that referenced
this pull request
Sep 11, 2026
Added in bytecodealliance#2555 but I forgot to document it at the time.
social4hyq
pushed a commit
to social4hyq/homebrew-core
that referenced
this pull request
Sep 20, 2026
wasm-tools 1.253.0 Created-by: HarmonybrewBot Commit-by: HarmonybrewBot Merged-by: HarmonybrewBot Description: Created by `brew bump` --- Created with `brew bump-formula-pr`.<details> <summary>release notes</summary> <pre>## What's Changed * Limit the element count of fixed-length lists by @eyupcanakman in bytecodealliance/wasm-tools#2537 * wasmparser: Rename BinaryReaderError to Error by @lann in bytecodealliance/wasm-tools#2546 * fix: signature lowering for strings and lists on modules with 64bit memory by @christoph-dfinity in bytecodealliance/wasm-tools#2544 * json-from-wast: name emitted files after the output stem by @eyupcanakman in bytecodealliance/wasm-tools#2542 * Refactor `KebabStr` to not require unsafe code by @alexcrichton in bytecodealliance/wasm-tools#2548 * Add CustomSectionReader -> BinaryReader conversion by @WorldSEnder in bytecodealliance/wasm-tools#2550 * wasmparser: Add Error::missing_wasm_feature by @lann in bytecodealliance/wasm-tools#2549 * fix: use ptr-sized type when returning via ptr indirection under memory64 by @christoph-dfinity in bytecodealliance/wasm-tools#2553 * Synchronize threading intrinsics with specification by @alexcrichton in bytecodealliance/wasm-tools#2554 * Remove `resource.drop async` by @alexcrichton in bytecodealliance/wasm-tools#2552 * Initial work for `versionsuffix` and `external-id` by @alexcrichton in bytecodealliance/wasm-tools#2555 * Make parsing errors downcastable by @PhoebeSzmucer in bytecodealliance/wasm-tools#2557 * Add `SourceMap::resolve_span` for resolving global span locations by @PhoebeSzmucer in bytecodealliance/wasm-tools#2559 * Render error by @PhoebeSzmucer in bytecodealliance/wasm-tools#2560 * Support `external-id` on more items by @alexcrichton in bytecodealliance/wasm-tools#2558 * Release wasm-tools 1.253.0 by @github-actions[bot] in bytecodealliance/wasm-tools#2561 ## New Contributors * @christoph-dfinity made their first contribution in bytecodealliance/wasm-tools#2544 **Full Changelog**: https://github.com/bytecodealliance/wasm-tools/compare/v1.252.0...v1.253.0</pre> <p>View the full release notes at <a href="https://github.com/bytecodealliance/wasm-tools/releases/tag/v1.253.0">https://github.com/bytecodealliance/wasm-tools/releases/tag/v1.253.0</a>.</p> </details> <hr> See merge request: Harmonybrew/homebrew-core!13746
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is intended to at least start laying groundwork and implementation for two features in the component model that this repository does not yet implement:
(versionsuffix "...")for components -- introduced in Interface version canonicalization WebAssembly/component-model#536 this is intended to pave a path forward to canonicalizing versions in component imports/exports in the future. For example where today you'd importa:b/c@1.0.0tomorrow you'd importa:b/c@1. This is not yet fully integrated intowit-component, however, and further work will be necessary for bindings generators as well to take advantage of this. It's all encoded in the same place asexternal-id, though, so I figured I'd at least start to lay the groundwork.(external-id "...")for components -- being introduced in Addexternal-idattribute WebAssembly/component-model#672 this is intended to attach arbitrary metadata to imports/exports in a component. This is surfaced in WIT as an@external-id("...")attribute. This should be hooked up throughout this implementation to WIT and such such that the implementation is intended to be complete. There's probably something I forgot, but all the major pieces should be there.The
versionsuffixparsing/validation is gated by a newcm-canon-namesfeature, and theexternal-idparsing/validation is gated behind the preexistingcm-implementsfeature to match the specification's classification.Closes #2551